Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node/edge highlighter objects immutable in app store #1173

Merged
merged 3 commits into from
Mar 16, 2016
Merged

Make node/edge highlighter objects immutable in app store #1173

merged 3 commits into from
Mar 16, 2016

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Mar 16, 2016

  • refactor
  • fixed reverse edge highlighting on node hover

foot
foot reviewed Mar 16, 2016
View reviewed changes
client/app/scripts/stores/app-store.js

// highlight nodes
highlightedNodeIds = highlightedNodeIds.add(nodeId);
const adjacencNodes = this.getAdjacentNodes(nodeId);

This comment was marked as abuse.

Sign in to view

@foot
Copy link
Contributor

foot commented Mar 16, 2016

Edges not going both ways but not sure if this is a regression

botways

@foot
Copy link
Contributor

foot commented Mar 16, 2016

but other than that LGTM.

@davkal
Copy link
Contributor Author

davkal commented Mar 16, 2016

Edges not going both ways but not sure if this is a regression

Not a regression. In this scenario 192... has scope-app in its adjacency list, but not the other way around. To fix this for a given nodeA , we need to check the adjacency list of all nodes, to see if nodeA is in any of their adjacency lists. This is already done a few lines above, so I can reuse that result.

@foot
Copy link
Contributor

foot commented Mar 16, 2016

noice, lgtm

davkal added a commit that referenced this pull request Mar 16, 2016
@davkal
Merge pull request #1173 from weaveworks/immutablejs-highlights
46cb135 
Make node/edge highlighter objects immutable in app store
@davkal davkal merged commit 46cb135 into master Mar 16, 2016
@davkal davkal deleted the immutablejs-highlights branch March 16, 2016 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@foot foot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davkal @foot