Fix make client-start

[davkal]

• removed --no-optional from npm install
• made webpack host configurable via env
• start via make WEBPACK_SERVER_HOST=local.docker client-start
• removed port from BACKEND_HOST env

Hot code reloading is not working yet (due to missing inotify support in OSX). You have to restart the container after a code change.

[2opremio]

This seems to be making progress in the right direction but:

• It takes quite a while to load the UI (~1 minute, I don't know if this is normal)
• The browser is freezes in Connecting to scope (it seems that the websocket is not working for some reason).

This is how I launch it (inside a virtual machine with IP 172.16.0.3 in my OSX laptop):

vagrant@vagrant-ubuntu-wily-64:~/scope$ make WEBPACK_SERVER_HOST=172.16.0.3 client-start
sudo -E docker run --rm -ti --net=host -v /home/vagrant/src/github.com/weaveworks/scope/client/app:/home/weave/app \
        -v /home/vagrant/src/github.com/weaveworks/scope/client/build:/home/weave/build -e WEBPACK_SERVER_HOST \
        weaveworks/scope-ui-build npm start

> weave-scope@1.2.0 start /home/weave
> node server.js

Scope UI listening at http://:::4042
Scope Proxy Path UI listening at http://:::4043/scoped/

This is the UI (connecting from a browser in my OSX laptop):

[davkal]

It takes quite a while to load the UI (~1 minute, I don't know if this is normal)

20-30 secs is normal for building the JS bundle.

The browser is freezes in Connecting to scope (it seems that the websocket is not working for some reason).

I had a similar issue. For me it was an old scope container running. This setup needs a scope container running to serve the backend. That scope version's API has to be compatible with the one you're running in client-start. After a make && ./scope stop && ./scope launch it worked for me.

[2opremio]

After a make && ./scope stop && ./scope launch it worked for me.

I had to make clean, but after that it worked (and I think hot code reloading will work just fine since I am running it in a VM).

[2opremio]

Thanks!

[2opremio]

(i.e. LGTM!)

[foot]

Expected code-changes outside container aren't detected/served up. But hosting works nicely!

LGTM