Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve canvas highlighting performance. #1239

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Improve canvas highlighting performance. #1239

merged 1 commit into from
Apr 7, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Apr 7, 2016

  • Untangle edge property dependencies so we don't redraw them all if a node is
    highlighted.
  • Only "preparePoints" if they've changed.
  • Helps smooth panning too, mouse will occasionally cross lines which can make things janky.

@foot
Improve highlighting performance.
c46baca 
- Untangle edge dependencies so we don't redraw them all if a node is
  highlighted.
- Only "preparePoints" if they've changed.
@davkal
Copy link
Contributor

davkal commented Apr 7, 2016

Great! LGTM

@foot foot merged commit de173a6 into master Apr 7, 2016
@foot foot deleted the improve-highlight-perf branch April 7, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davkal davkal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @davkal