Ensure k8s views are correctly hidden.

[tomwilkie]

• Filter unconnected psuedo nodes from the Pods view
• Don't report these filtered nodes in stats
• Fix typo in logic for hiding views

Fixes #1214

[tomwilkie]

@paulbellamy PTAL

[paulbellamy]

The number of nodes filtered still seem odd.

what 32 nodes are being filtered?

Edit: attached report
report.json.zip

[paulbellamy]

Also, I still think the SilentFilter thing seems overcomplicated and error-prone. e.g. It will still count the internet node being filtered out as part of the container renderer.

[tomwilkie]

The number of nodes filtered still seem odd.

I think the stats in the bottom left lag slightly; when I do this I get 39 NODES (7 FILTERED) (which is still wrong).

[paulbellamy]

Mine's been showing 12 nodes (34 filtered) for 28 minutes. When there are 39 nodes visible...

[tomwilkie]

Try refreshing? Otherwise its a UI bug.

[paulbellamy]

Ah yeah. Now I get 39 nodes (6 filtered), which is still wrong. It occurs to me that maybe any filters used in render/topologies.go should be silent, and only the ones applied (at the end) by the UI widget should count towards the (X filtered) statistic.

[tomwilkie]

@paulbellamy yup, I agree. Have made them all silent now; which also means we need to silently filter some non-pseudo nodes. WDYT?

[paulbellamy]

LGTM. I take back what I said about SilentFilter not being the right abstraction. When applied to all the internal filters, it's great.