Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice and red and blinky ui label for broken plugins #1280

Merged
merged 2 commits into from
Apr 13, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions client/app/scripts/components/plugins.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
import React from 'react';
import classNames from 'classnames';

export default class Plugins extends React.Component {
renderPlugin(plugin) {
renderPlugin({id, label, description, status}) {
const error = status !== 'ok';
const className = classNames({ error });
const title = error ?
`Status: ${status}. (Plugin description: ${description})` :

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

description;

// Inner span to hold styling so we don't effect the "before:content"
return (
<span className="plugins-plugin" key={plugin.id} title={plugin.description}>
{plugin.label || plugin.id}
<span className="plugins-plugin" key={id}>
<span className={className} title={title}>
{label || id}
</span>
</span>
);
}
Expand Down
2 changes: 1 addition & 1 deletion client/app/scripts/stores/app-store.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ let highlightedEdgeIds = makeSet();
let highlightedNodeIds = makeSet();
let hostname = '...';
let version = '...';
let plugins = null;
let plugins = [];

This comment was marked as abuse.

This comment was marked as abuse.

let mouseOverEdgeId = null;
let mouseOverNodeId = null;
let nodeDetails = makeOrderedMap(); // nodeId -> details
Expand Down
5 changes: 5 additions & 0 deletions client/app/styles/main.less
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,11 @@ h2 {
content: ', ';
}

.error {
animation: blinking 2.0s 30 @base-ease; // blink for 1 minute;
color: darkred;

This comment was marked as abuse.

}

&-empty {
opacity: @text-secondary-color;
}
Expand Down