-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker rename events #1332
Conversation
Backend LGTM, although am a little worries that it doesn't come through to the canvas. Is the backend sending the right data to the frontend @paulbellamy ? |
It shows the right data in the details panel, and when you refresh, but it doesn't in-place-update the canvas Edit: Which makes me suspect the JS. |
Details panel is polled though, whereas the canvas is a push ws from the app. |
The websocket is sending out the updated node label. |
Cool will get the canvas behaving. |
@davkal rfr not sure if this is the best way to do it? |
@@ -356,7 +353,7 @@ export default class NodesChart extends React.Component { | |||
|
|||
// inject metrics and save coordinates for restore | |||
const layoutNodes = graph.nodes | |||
.mergeDeep(nodeMetrics) | |||
.mergeDeep(stateNodes) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Looks like I added #1353 as a techdebt ticket to rewrite that part in |
FE is ready to merge @paulbellamy |
@foot What is the intended f/e behaviour? I've played with this and renaming does not update the UI. Even switching between views has no effect. However, the UI does update when hitting the 'redraw' button. |
Intended behaviour is immediate instantaneous UI updates! So fast it changes before you can alt-tab back from the terminal and check that it changed! Which is a bum, clear cache? I'll give it a quick test in Firefox now. #1354 Should help w/ the caching issues if it turns out to be that. |
That was it! |
Fixes #1091
@foot, doesn't propagate through to the canvas, just the details panel.