If k8s objects only have one container, show that container's metrics on them #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you not hit this? #1291 |
|
Am running docker 1.11 |
So am I. I just thought this was a thing. I even see it on GKE. |
|
Works fine for me? |
|
That's good I guess. I rather solve this will real ts aggregation, but as acts not going to happen in the next week, Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore the pause container with this, (even though it uses a bit of memory).
Not super-useful when you have pods/etc with > 1 container in them, but is a nice best-effort affordance when we can do it. Bit of a stop-gap until we have metric aggregation.