Use NATS for shortcut reports in the service. #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +97,11 @@ type DynamoDBCollector interface { | |||
| CreateTables() error | |||
| } | |||
|
|
|||
| type watchKey struct { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Very cool! I've made a few comments. Please address them as you see fit & merge when green. |
tomwilkie
force-pushed
the
nats-shortcut-reports
branch
from
f34a9d4 to
0826902
Compare
|
@jml PTAL |
| case waiter <- struct{}{}: | ||
| default: | ||
| } | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM, modulo a typo & optional additional test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue is NATS client fails on creation if it can't reach the NATS server. Am investigating a fix.