Make it easier to disable weave integrations #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From #1078
I can't see this being implemented |
|
Good catch! PTAL |
|
LGTM |
| weaveHostname string | ||
| ) | ||
|
|
||
| // Flags that apply to both probe and app | ||
| flag.StringVar(&mode, "mode", "help", "For internal use.") | ||
| flag.BoolVar(&debug, "debug", false, "Force debug logging.") | ||
| flag.BoolVar(&weaveEnabled, "weave", true, "Enable Weave Net integrations.") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
1599-1078-1008
branch
from
d85fd33 to
b07863d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
weave psexit code like any other error (so we silence it if its failing all the time) (fixes failed weave interactions are logged as errors, even though it's normal operation #1599)