Promote fixprobe and delete rest of experimental #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the example subdirectory? It doesn't require building, and is very useful. Otherwise I'm happy with this, but we should check with others. |
extras contains fixprobe and example, and ought to build properly
jml
changed the title
|
Am still happy, but I think you should also get @paulbellamy and @2opremio's LGTM. |
|
Maybe |
|
Not fussy about that though, LGTM. |
|
Really no preference at all. Will rename after @2opremio has had a chance to look, in case he has a preference. |
|
LGTM |
|
There's already a Thanks for the reviews! |
rade
added a commit
that referenced
this pull request
Dec 17, 2017
It is unused and none of the adjacency mapping code in the renderer takes any notice of it. Removing this shrinks the report size. Edges were introduced in #838. At the time we had an experimental packet sniffer under experimental/sniff/sniffer.go. That got removed in #1646. We can resurrect this if we ever decide to add meta data to edges.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need experimental, there are better ways of experimenting with code, and sometimes they fail the build, which gets in the way of making changes to scope.
This PR deletes the experimental directory, but promotes
fixprobe, which I'm told we use.This change is