Fix ensure plugins dir exists (close #1649)

[errordeveloper]

No description provided.

[errordeveloper]

I think it'd great to make a patch release. @lukemarsden and I would like to publish a guide using socks shop and Scope on Docker for Mac.

[tomwilkie]

Why is this needed for a patch release? Is it fixing some important
blocking issue?

On Wednesday, 6 July 2016, Ilya Dmitrichenko notifications@github.com
wrote:

I think it'd great to make a patch release. @lukemarsden
https://github.com/lukemarsden and I would like to publish a guide
using socks shop and Scope on Docker for Mac.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1650 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAbGhQIUs-3QohUyVf15DWcE_SAhrKw-ks5qS-5ZgaJpZM4JGWIL
.

[tomwilkie]

Oh I see #1649. Sorry.

On Wednesday, 6 July 2016, Tom Wilkie tom@weave.works wrote:

Why is this needed for a patch release? Is it fixing some important
blocking issue?

On Wednesday, 6 July 2016, Ilya Dmitrichenko notifications@github.com
wrote:

I think it'd great to make a patch release. @lukemarsden
https://github.com/lukemarsden and I would like to publish a guide
using socks shop and Scope on Docker for Mac.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1650 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAbGhQIUs-3QohUyVf15DWcE_SAhrKw-ks5qS-5ZgaJpZM4JGWIL
.

[2opremio]

I think it'd great to make a patch release. @lukemarsden and I would like to publish a guide using socks shop and Scope on Docker for Mac.

I think we are pretty close to finish the 0.17 milestone

[2opremio]

@errordeveloper I would only explicitly create the directory in the Docker4Mac case and add a comment about why (e.g. incompatible with standard docker in which the directory is created if it doesn't exist)

[errordeveloper]

I would only explicitly create the directory in the Docker4Mac case

Perhaps, now that we learned about the behaviour being undepricated...

incompatible with standard docker in which the directory is created if it doesn't exist

That's actually not the case, if you take a look at #1649, the reason is a bit different.

[2opremio]

That's actually not the case, if you take a look at #1649, the reason is a bit different.

Sure, I was just providing a possible comment. My point was explaining the cause and only applying the fix for Docker4mac.

[errordeveloper]

@2opremio I've addressed your concerns and rebased.

[2opremio]

Thanks @errordeveloper !

LGTM