Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stats gathering idempotent #1798

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Aug 16, 2016

Leftover from #1683 , found while diagnosing #1795

@rade
Copy link
Member

rade commented Aug 16, 2016

LGTM

@2opremio 2opremio force-pushed the 1683-start-stats-idempotent branch from 6ce19fa to 8b97f12 Compare August 16, 2016 12:55
@ekimekim
Copy link
Contributor

There's a race where StartGatheringStats() could get called twice, and the second call happens before the line c.statsConn = conn is reached, so we'll start a second goroutine and have two things gathering stats.
But that's not a regression in this particular PR, so LGTM.

@2opremio
Copy link
Contributor Author

There's a race where StartGatheringStats() could get called twice, and the second call happens before the line c.statsConn = conn is reached, so we'll start a second goroutine and have two things gathering stats.

Good catch, would you mind filing a bug for it?

@2opremio 2opremio merged commit fc4bdf0 into release-0.17 Aug 16, 2016
@2opremio 2opremio deleted the 1683-start-stats-idempotent branch August 16, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants