Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend kubernetes client flags to match kubectl #1813

Merged
merged 7 commits into from
Aug 18, 2016
Merged

Extend kubernetes client flags to match kubectl #1813

merged 7 commits into from
Aug 18, 2016

Conversation

2opremio
Copy link
Contributor

Fixes #1810

Alfonso Acosta added 2 commits August 17, 2016 15:15
Vendor github.com/imdario/mergo
e9235a5 
In order to use k8s.io/kubernetes/pkg/client/unversioned/clientcmd/client_config.go
Extend kubernetes client flags to match kubectl
1bdff95
@2opremio
Copy link
Contributor Author

2opremio commented Aug 17, 2016 •
edited
Loading

@mindfulmonk would you mind testing this to confirm it solves your problem? You can use the Docker image weaveworks/scope:1810-extend-k8s-client-flags-1bdff95

@mindfulmonk
Copy link

@2opremio Not a problem, just waiting for it to appear in https://hub.docker.com/r/weaveworks/scope/tags/ ;)

@2opremio
Copy link
Contributor Author

@2opremio Not a problem, just waiting for it to appear in https://hub.docker.com/r/weaveworks/scope/tags/ ;)

Ops, please try again, it should be there now

@2opremio
Copy link
Contributor Author

Circle is incorrectly bitching about spelling mistakes.

@paulbellamy
Copy link
Contributor

If you don't provide a kubernetes context, will it use the current context?

@2opremio
Copy link
Contributor Author

If you don't provide a kubernetes context, will it use the current context?

Yes, just like kubectl (that's what my experimentation shows with our service kubeconfig files).

@2opremio 2opremio force-pushed the 1810-extend-k8s-client-flags branch from 51230e8 to 4b0f152 Compare August 18, 2016 14:57
@2opremio 2opremio force-pushed the 1810-extend-k8s-client-flags branch from 3d124f9 to f8a67a4 Compare August 18, 2016 15:33
jml
jml reviewed Aug 18, 2016
View reviewed changes
probe/kubernetes/client.go
}
log.Infof("kubernetes: targetting api server %s", restConfig.Host)

This comment was marked as abuse.

Sign in to view

@jml
Copy link
Contributor

jml commented Aug 18, 2016

LGTM, modulo spelling mistake.

@2opremio 2opremio merged commit 8e5ff2a into release-0.17 Aug 18, 2016
@2opremio 2opremio deleted the 1810-extend-k8s-client-flags branch August 18, 2016 17:23
@2opremio 2opremio mentioned this pull request Aug 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jml jml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2opremio @mindfulmonk @paulbellamy @jml