Add support for snooping DNS over TCP #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to the length field not being handled properly. |
2opremio
changed the title
2opremio
force-pushed
the
snoop-tcp-dns
branch
from
7c0ccda to
326208c
Compare
rade
reviewed
Sep 23, 2016
| @@ -111,12 +111,38 @@ func (s *DNSSnooper) Stop() { | |||
| } | |||
| } | |||
|
|
|||
| // Gopacket doesn't provide direct support for DNS over TCP, see https://github.com/google/gopacket/issues/236 | |||
| // TODO: deal with TCP fragmentation and out-of-order segments | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<probe> ERRO: 2016/09/23 12:38:29.891534 DNSSnooper: error decoding packet: qname '0x40' - RFC 2673 unsupported yet (data=77 index=17)