Allow resizing on attached pipes too.

[foot]

Fixes #1977

[errordeveloper]

It works in general, i.e. the terminal uses full-width:

And resizing affects environment variables:

However, having resized to a very large size, and making it smaller again leads to shell prompt way below the last visible line. I'm not sure if this is something we may be able to fix, or it's a more general issue, I still don't fully grasp how exactly this stuff works.

[errordeveloper]

However, having resized to a very large size, and making it smaller again leads to shell prompt way below the last visible line. I'm not sure if this is something we may be able to fix, or it's a more general issue, I still don't fully grasp how exactly this stuff works.

Having observed it my initial test, I am not able to reproduce it now... I think this may be a separate issue to do some kind of edge-case. I'll report if I see it again, this PR LGTM 👍

[2opremio]

@errordeveloper The exec terminals (>_) are not relevant for this PR. Did you test the logs (attach)?

[2opremio]

@foot It would be cool if the control icon could be placed on a top corner of the terminal window (to know what control triggered it)

[davkal]

LGTM

[errordeveloper]

I've retested with logs.

Here is first one, looks good.

However, making the window wider doesn't reflow the log lines.

But closing and re-opening works ok.

Making the window smaller and larger again leave empty space...

[2opremio]

Thanks @errordeveloper, better late than never. Can you please create an issue with this?