Fix Safari terminal window height bug #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bowenli could you review? |
|
@foot Could you take a look at this? |
|
Its kind of a fun effect where it slides out compact and then grows vertically. Nice catch on making the terminal padding "border" black to match the term. |
Safari wasn't supporting a "badly specified"[0] layout that Chrome was supporting. [0] Height 100% inside of a container that didn't have a height specified.
Fixes console errors
foot
force-pushed
the
1986-safari-terminal
branch
from
45e3296 to
127ab41
Compare
|
I changed the solution a bit and instead fixed up the CSS layout so that height was propagated down the DOM tree in Safari. All the nesting for the Terminal here is a bit icky, mix of absolute+top0+bottom0 and height 100%s but works for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1986
Fixes the issue where the terminal in Safari isn't the right size.
Before:
After: