Add anti-dance heuristics (and feature flags) #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davkal
changed the title
foot
reviewed
Nov 21, 2016
| @@ -197,6 +201,66 @@ class DebugToolbar extends React.Component { | |||
| })); | |||
| } | |||
|
|
|||
| setIntermittend() { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| }), nodeNames.length), | ||
| remove: this._removeNode(), | ||
| })); | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new special cases that will not trigger a full re-layout:
Both heuristics are disabled by default and can be enabled via feature flags, which are introduced here as well (see
utils/feature-utils):In the console you can set
localStorage['scope-experimental:layout-dance'] = trueto try them out.Related to #1033