Upgraded eslint & eslint-config-airbnb

[fbarl]

There is a bunch of new lint rules that I temporarily switched off, because they either require changes across multiple files or I wasn't sure whether we wanted to override them in some way.

@davkal, @foot: I will be working on resolving some of the items from the list on my own now, but I'm sure there will be at least a couple of them which we'll need to discuss. As I expect we'll soon be upgrading eslint on service-ui as well, maybe @jpellizzari & @bowenli would also like to contribute if they feel we should disable/override some of these rules:

• import/first used
• import/prefer-default-export - disabled
• import/no-extraneous-dependencies - used, but only for dependencies, which is forcing the used D3 modules to be listed explicitly in package.json; the default rule would force us to move some react dev stuff from devDependencies to dependencies
• import/no-named-as-default used
• jsx-a11y/no-static-element-interactions - disabled, at least for now as it applies to a lot of elements and in some cases it seems too strict
• jsx-a11y/label-has-for - used
• react/jsx-indent used
• react/jsx-filename-extension - tweaked like @jpellizzari posted below
• react/jsx-first-prop-new-line used
• react/jsx-no-target-blank - used
• react/no-find-dom-node - used
• react/no-string-refs used
• react/self-closing-comp used
• react/forbid-prop-types - used
• no-plusplus used
• no-mixed-operators - used
• no-restricted-properties - disabled, as we get warnings for using ** instead of Math.pow which is only a part of ES2017 syntax that Airbnb uses, but we don't
• no-underscore-dangle - used
• arrow-parens - used
• class-methods-use-this - used, but pulled such functions out of component logic and made them helpers instead of class static methods
• global-require - disabled because of how our hot loading is set up

Note: I will be removing the items from this list as I resolve them

[jpellizzari]

Here is the .eslintrc file I have been using with version 13.0.0 of eslint-config-airbnb.

{
  "extends": "airbnb",
  "parser": "babel-eslint",
  "env": {
    "browser": true,
    "jest": true,
    "node": true
  },
  "rules": {
    "one-var" : 0,
    "one-var-declaration-per-line": 0,
    "func-names": 0,
    "class-methods-use-this": 0,
    "import/prefer-default-export": 0,
    "import/no-named-as-default" : 0,
    "import/no-webpack-loader-syntax": 0,
    "import/no-extraneous-dependencies": [
      "error",
      {
        "devDependencies": true,
        "optionalDependencies": true,
        "peerDependencies": true
      }
    ],
    "react/jsx-filename-extension": [
      2,
      {
        "extensions": [
          ".js",
          ".jsx"
        ]
      }
    ],
    "comma-dangle": 0,
    "no-param-reassign": 0,
    "object-curly-spacing": 0,
    "react/jsx-closing-bracket-location": 0,
    "react/prefer-stateless-function": 0,
    "react/sort-comp": 0,
    "react/prop-types": 0,
    "jsx-a11y/no-static-element-interactions" : 0
  }
}

[jpellizzari]

Mostly just questions for you @fbarl . Nice work!

[davkal]

Massive changeset, and a good step forward. A quick functional test of the UI did not reveal any errors.

I think renaming those JSX functions would add additional clarity.

Otherwise LGTM

[jpellizzari]

LGTM