Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Make service a parent of task #2091

Closed
wants to merge 1 commit into from

Conversation

ekimekim
Copy link
Contributor

Fixes #2041

@2opremio
Copy link
Contributor

Did you test it in the UI?

@2opremio 2opremio removed their assignment Dec 14, 2016
@2opremio 2opremio self-requested a review December 14, 2016 10:48
@ekimekim
Copy link
Contributor Author

not yet

@2opremio
Copy link
Contributor

We may need to modify the rendering code for service parents to show on the details panel (I am not sure).

@2opremio
Copy link
Contributor

I at least expect #2040 to require changes in rendering.

@ekimekim
Copy link
Contributor Author

ekimekim commented Jan 21, 2017

Turns out the render code already does this implicitly, which is fine for now.
I may come back to this branch to remove that special-case and do it in the report properly, instead.

@2opremio
Copy link
Contributor

@ekimekim ping

@2opremio
Copy link
Contributor

@ekimekim re-ping :)

@ekimekim
Copy link
Contributor Author

Closing in favor of #2436, since this is required for that and it's easier than stacking PRs on each other.

@ekimekim ekimekim closed this Apr 11, 2017
@ekimekim ekimekim deleted the mike/ecs/parent-task-service branch April 11, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants