prog/main: use flags.app.port for default target #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can control the webserver listen address with `-app.http.address`. If they do, `scope --mode probe ...` should use the port part of address in the default target and not ':4040'. Otherwise we encounter a `dial tcp 127.0.0.1:4040: getsockopt: connection refused` error and `scope-probe` cannot report. Signed-off-by: Michael Schubert <michael@kinvolk.io>
|
Not perfect as the |
|
Thanks @schu
It wasn't perfect before either (i.e. you could already listen on an different address) |
|
Related: #1190 |
2opremio
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can control the webserver listen address with
-app.http.address.If they do,
scope --mode probe ...should use the port part of addressin the default target and not ':4040'. Otherwise we encounter a
dial tcp 127.0.0.1:4040: getsockopt: connection refusederror andscope-probecannot report.Signed-off-by: Michael Schubert michael@kinvolk.io