Maintain focus on hovered node table rows #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
node-table-maintain-focus
branch
2 times, most recently
from
933f6bb to
9dfc19a
Compare
fbarl
changed the title
davkal
reviewed
Jan 11, 2017
|
|
||
|
|
||
| const log = debug('scope:table'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
davkal
approved these changes
Jan 11, 2017
| focusedRowIndex: rowIndex, | ||
| focusedNode: node | ||
| }); | ||
| log(`Focused row ${rowIndex}`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| focusedRowIndex: null, | ||
| focusedNode: null | ||
| }); | ||
| log('Unfocused row'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| if (nodeRowIndex >= 0) { | ||
| // If the focused node still exists in the table, we move it | ||
| // to the hovered row, keeping the rest of the table sorted. | ||
| moveElement(nodes, nodeRowIndex, focusedRowIndex); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| } | ||
|
|
||
| onMouseEnterRow(rowIndex, node) { | ||
| this.debouncedUnfocusRow.cancel(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
fbarl
changed the title
|
@davkal and I discovered that row focusing was actually not working under some special conditions so I'm still working on this trying to cover all the cases. |
fbarl
force-pushed
the
node-table-maintain-focus
branch
4 times, most recently
from
708f52e to
2a70393
Compare
|
@davkal This slightly hacky solution should now work for all cases. PTAL. |
fbarl
changed the title
fbarl
force-pushed
the
node-table-maintain-focus
branch
2 times, most recently
from
3432a7c to
da1c6f5
Compare
davkal
approved these changes
Jan 20, 2017
| @@ -188,10 +261,11 @@ export default class NodeDetailsTable extends React.Component { | |||
| colStyles={styles} | |||
| columns={columns} | |||
| onClick={onClickRow} | |||
| onMouseLeaveRow={onMouseLeaveRow} | |||
| onMouseEnterRow={onMouseEnterRow} | |||
| onMouseEnter={() => { this.onMouseEnterRow(index, node); }} | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -1,13 +1,15 @@ | |||
| import React from 'react'; | |||
| import classNames from 'classnames'; | |||
| import { find, get, union, sortBy, groupBy, concat } from 'lodash'; | |||
| import { find, get, union, sortBy, groupBy, concat, debounce, findIndex } from 'lodash'; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| // Use debouncing to prevent event flooding when e.g. crossing fast with mouse cursor | ||
| // over the whole table. That would be expensive as each focus causes table to rerender. | ||
| this.debouncedFocusRow = debounce(this.focusRow, TABLE_ROW_FOCUS_DEBOUNCE_INTERVAL); | ||
| this.debouncedUnfocusRow = debounce(this.unfocusRow, TABLE_ROW_FOCUS_DEBOUNCE_INTERVAL); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
More sophisticated row focusing Keeping deleted focused nodes in the table Fixed focus debouncing
fbarl
force-pushed
the
node-table-maintain-focus
branch
from
da1c6f5 to
1ef64cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1738. On hovering over a node in the table view, the row freezes its position until it loses focus. We only do that for the hovered row (and not for the selected one), with a short debounce to prevent excessive re-rendering. We keep the removed node's row in the table as long as it's focused so that the row would have a real freeze effect.
I think the best way to test this PR is by setting short lived nodes in the debug toolbar. To increase the table dynamics, I suggest temporarily dropping the constant in
debug-toolbar.js:232to100.