Fix ownership issues with client/build-external #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may consider using a |
ekimekim
force-pushed
the
mike/track-build-external
branch
from
8267df0 to
e87fb80
Compare
|
done. PTAL? |
|
LGTM, CI failed though |
fixed by #2158, so I'll rebase on master to pick it up |
When the directory is created during the build process, it is as root. This prevents us deleting root-owned files inside the directory during make clean. In client/build/, we get around this because the directory contains a tracked file, so it's created during git checkout. We make this the case for build-external by adding a hidden, empty file to track. This won't fix existing checkouts though, so we also add a fix-up step to make clean. The use of .gitignore as the empty file to track is taken from https://git.wiki.kernel.org/index.php/GitFaq#Can_I_add_empty_directories.3F Specifically: "If you really need a directory to exist in checkouts you should create a file in it. .gitignore works well for this purpose"
ekimekim
force-pushed
the
mike/track-build-external
branch
from
e87fb80 to
02a2dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the directory is created during the build process, it is as root.
This prevents us deleting root-owned files inside the directory during make clean.
In client/build/, we get around this because the directory contains a tracked file,
so it's created during git checkout.
We make this the case for build-external by adding a hidden, empty file to track.
This won't fix existing checkouts though, so we also add a fix-up step to make clean.
Fixes #2031