Add logic to remove non-transferrable state when switching Cloud instances #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
change-instance
branch
from
e96ad0d to
6545c19
Compare
|
@fbarl Could you take a look please? |
fbarl
reviewed
Feb 14, 2017
There was a problem hiding this comment.
Nice PR! Looks much more elegant than what I did here https://github.com/weaveworks/service-ui/pull/198 - I suppose that code will be dropped once you make this work from Scope?
client/app/scripts/reducers/root.js
Outdated
| @@ -721,6 +721,12 @@ export function rootReducer(state = initialState, action) { | |||
| return state.set('showingTroubleshootingMenu', !state.get('showingTroubleshootingMenu')); | |||
| } | |||
|
|
|||
| case ActionTypes.CHANGE_INSTANCE: { | |||
| state = state.set('selectedNodeId', null); | |||
| state = state.update('nodeDetails', nodes => nodes.clear()); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -61,6 +61,7 @@ | |||
| "eslint-plugin-import": "2.2.0", | |||
| "eslint-plugin-jsx-a11y": "2.2.3", | |||
| "eslint-plugin-react": "6.8.0", | |||
| "expect": "^1.20.2", | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
jpellizzari
force-pushed
the
change-instance
branch
2 times, most recently
from
8d54fcc to
65ca56a
Compare
fbarl
reviewed
Feb 15, 2017
client/app/scripts/reducers/root.js
Outdated
| @@ -721,6 +721,12 @@ export function rootReducer(state = initialState, action) { | |||
| return state.set('showingTroubleshootingMenu', !state.get('showingTroubleshootingMenu')); | |||
| } | |||
|
|
|||
| case ActionTypes.CHANGE_INSTANCE: { | |||
| state = state.set('selectedNodeId', null); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
jpellizzari
force-pushed
the
change-instance
branch
from
65ca56a to
3d13e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change needed for https://github.com/weaveworks/service-ui/pull/184
This moves the logic added in https://github.com/weaveworks/service-ui/pull/198 to Scope. In the near future, service-ui will interact with Scope via Scope's public JS API, so manipulating the iframe URL state will not be a viable option for preventing instance-specific state from transferring when the user changes instances.