Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed a copy of weaveutil instead of calling via docker #2278

Merged
merged 3 commits into from
Feb 24, 2017

Conversation

bboreham
Copy link
Collaborator

Scope calls the weave script, which checks to see if it can exec weaveutil directly and, if not, execs it via a Docker image weaveexec. This PR downloads that image and copies the binary into the Scope image, which saves all the indirection and overhead of running Docker every time.

This mechanism is used when weave ps is run, which is every few seconds.

Makefile Outdated
chmod u+x docker/weave

$(SCOPE_EXPORT): $(SCOPE_EXE) $(DOCKER_DISTRIB) docker/weave $(RUNSVINIT) docker/Dockerfile docker/demo.json docker/run-app docker/run-probe docker/entrypoint.sh
docker/weaveutil:
docker pull weaveworks/weaveexec:$(WEAVENET_VERSION)

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@2opremio
Copy link
Contributor

Paves the way for #2276

@2opremio 2opremio merged commit bc1c964 into master Feb 24, 2017
@2opremio
Copy link
Contributor

2opremio commented Feb 24, 2017

Also, should solve the problem of dead weavexec containers piling up, from a user in #weave-users: https://weaveworks.slack.com/archives/weave-users/p1487283019002156

Hey guys. I'm seeing some odd behavior with weavescope on Kubernetes. At one point in my cluster, there were over 4000 dead weaveexec containers, and it was growing. It seemed that something was launching weaveexec on the masters about every minute. After poking around a bit, I killed the weave-scope-agent DaemonSet, and that noticed that the weaveexec count stopped. To confirm, I recreated the DaemonSet, and the count started increasing again. Is this normal behavior? What exactly does weaveexec do?

@rade rade deleted the copy-weaveutil branch July 5, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants