-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed a copy of weaveutil instead of calling via docker #2278
Conversation
Makefile
Outdated
chmod u+x docker/weave | ||
|
||
$(SCOPE_EXPORT): $(SCOPE_EXE) $(DOCKER_DISTRIB) docker/weave $(RUNSVINIT) docker/Dockerfile docker/demo.json docker/run-app docker/run-probe docker/entrypoint.sh | ||
docker/weaveutil: | ||
docker pull weaveworks/weaveexec:$(WEAVENET_VERSION) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
08af60b
to
9c2009f
Compare
Paves the way for #2276 |
Also, should solve the problem of dead weavexec containers piling up, from a user in #weave-users: https://weaveworks.slack.com/archives/weave-users/p1487283019002156
|
Scope calls the
weave
script, which checks to see if it can execweaveutil
directly and, if not, execs it via a Docker imageweaveexec
. This PR downloads that image and copies the binary into the Scope image, which saves all the indirection and overhead of running Docker every time.This mechanism is used when
weave ps
is run, which is every few seconds.