Add AMI docs into main docs, modified weave token instructions in one place #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix the ECS guide when we merge this to get the ids from here |
|
I'll make a PR over in Guides for this. |
|
@abuehrle Please update the PR to cover the changes from weaveworks/integrations#123 and weaveworks/integrations#124. I will happily update the guides and make https://github.com/weaveworks/integrations/blob/master/aws/ecs/README.md point to the website once this PR is deployed. |
|
@2opremio addressed weaveworks/integrations#123 |
|
@abuehrle The AMI IDs also changed |
2opremio
approved these changes
Mar 29, 2017
|
Please let me know when you deploy this on the website so that I can update the guides and remove the docs from https://github.com/weaveworks/integrations/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@2opremio I've added the AMI doc to the main docs.
Place the doc after installing.md and also changed the title, so we'll need to update the guide as well.
Let me know if there is anything else we need to add in here.
(Also modified an instance of the weave token. )