Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn package manager #2368

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Use yarn package manager #2368

merged 2 commits into from
Mar 22, 2017

Conversation

jpellizzari
Copy link
Contributor

Implements #2090 and (hopefully) fixes #2367

Adds yarn and a lockfile for deterministic builds.

@jpellizzari jpellizzari self-assigned this Mar 21, 2017
@jpellizzari jpellizzari requested a review from fbarl March 21, 2017 21:00
@jpellizzari
Copy link
Contributor Author

@fbarl Could you review please?

Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean PR!

I am going to merge it straight away, as it might be blocking Scope development.

An idea for later is to try to use yarn --production flag in the prod env (if it's not already being appended somewhere in deployment) -
https://yarnpkg.com/en/docs/cli/install#toc-yarn-install-production

@fbarl fbarl merged commit b52e0ee into master Mar 22, 2017
@jpellizzari
Copy link
Contributor Author

@fbarl I'm pretty sure yarn --production will skip devDepenedencies, which we need to build in the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static assets failed to load
2 participants