gzip: change compression level to the default #2437
Conversation
We want the middle ground between a small compression size, a fast compression time and a fast decompression time. Tests suggest that the default compression level is better than the maximum compression level: although the reports are 4% bigger and decompress slower, they compress 33% faster. See discussion on weaveworks#1457 (comment)
|
@bboreham what do you think of this change? |
|
@ekimekim: PTAL |
|
Out of interest, did you test any other compression algorithms? For example, lz4 is generally my goto for fast compression/decompression, but I don't know how badly it would increase compressed size. |
|
(feel free to merge as-is without answering, it was just for my own curiosity) |
|
The problem with moving to a different compression scheme is that we'd have to change both client and server, and maintain backwards-compatibility in the server. With gzip, the same server code will decode data encoded at any level of compression. |
I tested other compression algorithms but outside of Scope and I didn't try lz4: I used a msgpack generated by Scope though.
@ekimekim I don't have merge rights, so I'll let you do it. |
We want the middle ground between a small compression size, a fast
compression time and a fast decompression time.
Tests suggest that the default compression level is better than the
maximum compression level: although the reports are 4% bigger and
decompress slower, they compress 33% faster.
See discussion on #1457 (comment)