New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close s3 response body to prevent leaks #2442

Merged

rade merged 1 commit into master from 2018-close-s3-response

Apr 14, 2017

Member

rade commented Apr 13, 2017

We do exactly this in https://github.com/weaveworks/cortex/blob/master/chunk/aws_storage_client.go#L335

Fixes #2018.


          close s3 response body to prevent leaks

46f288b

Fixes #2018

rade requested a review from ekimekim

April 13, 2017 23:31

ekimekim approved these changes

View reviewed changes

rade merged commit 76253c3 into master

rade deleted the 2018-close-s3-response branch

July 5, 2017 13:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet