parallel reduce #2561
Merged
parallel reduce #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't start the same piece of work twice
2opremio
reviewed
Jun 5, 2017
| for _, renderer := range *r { | ||
| result = result.Merge(renderer.Render(rpt, dct)) | ||
| renderer := renderer // Pike!! |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I am really curious as to how this performs in busy machines with many cores, merging reports from many probes. |
2opremio
approved these changes
Jun 5, 2017
|
Really small patch for such a performance improvement BTW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute reducer branches in parallel.
This reduces the time it takes to fetch topologies. Using the same test methodology is as in #2559 (comment), running on my feeble laptop...
(all results in seconds)