Back off upon errored kubernetes api requests #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Jun 5, 2017
probe/kubernetes/client.go
Outdated
| wait := resyncPeriod | ||
| for { | ||
| func() { | ||
| defer runtime.HandleCrash() |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@rndstr Do you think you could reuse |
|
@2opremio thanks for the suggestion, looks much cleaner now. I also stumbled over an inconsistency regarding logging errors in the backoff code, fix in the common repo: weaveworks/common#42 |
2opremio
reviewed
Jun 6, 2017
probe/kubernetes/client.go
Outdated
| "io" | ||
| "strconv" | ||
| "sync" | ||
| "time" | ||
|
|
||
| log "github.com/Sirupsen/logrus" | ||
| "github.com/weaveworks/common/backoff" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1009