-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API calls with time travel timestamp #2600
Make API calls with time travel timestamp #2600
Conversation
6a87b15
to
19552d6
Compare
app/api_topologies.go
Outdated
@@ -415,6 +415,16 @@ type topologyStats struct { | |||
FilteredNodes int `json:"filtered_nodes"` | |||
} | |||
|
|||
// deserializedTimestamp converts the ISO8601 query param into a proper timestamp. | |||
func deserializedTimestamp(timestampStr string) time.Time { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Backend code LGTM (modulo minor naming nits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only one question about Go error handling. I am assuming we are going to do another iteration on the UI design for time travel? The feature itself is not very prominent, but I can save that feedback if we are doing another round of changes.
app/api_topologies.go
Outdated
// If no timestamp is given, assume the current time. | ||
timestamp := time.Now() | ||
if timestampStr != "" { | ||
timestamp, _ = time.Parse(time.RFC3339, timestampStr) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@jpellizzari Yes! #2608 is the design follow-up issue, thanks for reminding me to reference it here. |
e5850e7
to
c65b510
Compare
c65b510
to
2d8437f
Compare
Fixes #2609. Now we (hopefully) only need to adress #2608 before removing the feature flag.
Changes
Pain points
<AutoRefreshable />
component.nodesByTopology
global state instead ofnodes
- would be nice to unify these two global states into one.