Time Travel: remove the feature flag and make the availability depend on historic reports capability #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndstr
reviewed
Jul 21, 2017
client/app/scripts/reducers/root.js
Outdated
| plugins: action.plugins, | ||
| versionUpdate: action.newVersion | ||
| version: action.version, | ||
| // TODO: Why is that one never forwarded here? |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
fbarl
force-pushed
the
use-report-persistence-flag-in-the-ui
branch
from
483cb76 to
f52f0e9
Compare
rade
reviewed
Jul 31, 2017
| isResourceViewModeSelector, | ||
| ], | ||
| (hasReportPersistence, isResourceViewMode) => hasReportPersistence && !isResourceViewMode | ||
| ); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
changed the title
fbarl
force-pushed
the
use-report-persistence-flag-in-the-ui
branch
from
acd1846 to
d460c2b
Compare
fbarl
changed the title
fbarl
force-pushed
the
use-report-persistence-flag-in-the-ui
branch
from
3e2421a to
f988276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2607 and removes the feature flag - this will finally make Time Travel appear on production.