Ignore ipv6 #2622
Merged
Ignore ipv6 #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in paying attention to them since scope connection tracking only deals in IPv4.
|
Uhm, my only reservation about this is that we should probably be moving closer to support ipv6 instead of going way from it. Granted, it doesn't make sense to waste resources on tracking ipv6 networks if we don't support ipv6 right now, but maybe we should be making easy to reenable it instead of simply removing all the code? |
|
Although, after thinking a bit more about it, it's just a matter of removing |
2opremio
approved these changes
Jun 20, 2017
Exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in paying attention to them since scope connection tracking only deals in IPv4.
In Weave Cloud Prod, 138 of the 218 local networks in the combined report are IPv6 addresses. That slows down endpoint projection during rendering since that needs to detect whether an address is local. This PR doesn't solve that completely - matching against 80 networks is still expensive - but I have plans for that :)