Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit per-host Uncontained pseudo nodes. #264

Merged
merged 1 commit into from
Jun 22, 2015
Merged

Emit per-host Uncontained pseudo nodes. #264

merged 1 commit into from
Jun 22, 2015

Conversation

tomwilkie
Copy link
Contributor

Fixes #127

@tomwilkie tomwilkie force-pushed the 127-per-host-uncontained branch from 84c96b3 to 24d24c6 Compare June 19, 2015 13:22
peterbourgon
peterbourgon reviewed Jun 19, 2015
View reviewed changes
render/topologies_test.go
render.UncontainedID: {
ID: render.UncontainedID,
fmt.Sprintf("%s:%s", render.UncontainedID, serverHostName): {
ID: fmt.Sprintf("%s:%s", render.UncontainedID, serverHostName),

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@peterbourgon
Copy link
Contributor

As far as I understand, this will split up the current singleton Uncontained pseudonode in both of the UI container topologies into per-host Uncontained pseudonodes. Is that correct?

@tomwilkie
Copy link
Contributor Author

That's the plan, yes

On Friday, 19 June 2015, Peter Bourgon notifications@github.com wrote:

As far as I understand, this will split up the current singleton
Uncontained pseudonode in both of the UI container topologies into per-host
Uncontained pseudonodes. Is that correct?

—
Reply to this email directly or view it on GitHub
#264 (comment).

@peterbourgon
Copy link
Contributor

LGTM after that one added comment.

@peterbourgon peterbourgon removed their assignment Jun 20, 2015
@tomwilkie tomwilkie force-pushed the 127-per-host-uncontained branch from 24d24c6 to 25016db Compare June 22, 2015 10:35
tomwilkie added a commit that referenced this pull request Jun 22, 2015
@tomwilkie
Merge pull request #264 from tomwilkie/127-per-host-uncontained
99d7977 
Emit per-host Uncontained pseudo nodes.
@tomwilkie tomwilkie merged commit 99d7977 into weaveworks:master Jun 22, 2015
@tomwilkie tomwilkie deleted the 127-per-host-uncontained branch June 22, 2015 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomwilkie @peterbourgon