-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time travel redesign #2651
Time travel redesign #2651
Conversation
@fbarl Please could you add the final screenshot/mockup of the parts you're implementing in this phase? |
66a6817
to
8119e13
Compare
@pidster @rade I'm using this mockup as my main reference for this PR, but I think there will be some tiny changes to the wording and spacing. FYI @bia is already sketching a new version that we might want to switch to when we add some metadata (thus transforming slider into a real timeline). |
Here's a particular use case I'd like us to be able to support: "binary search" to pinpoint when the system transitioned from a "good" state to a "bad" state, for example as a result of me discovering some hitherto hidden anomaly now, and suspecting that it may well have been around for a very long time. I should be able to do that only using the controls, without having to do mental time arithmetic. Here' roughly how I would envisage that to work...
There are obviously other ways of doing this. The two crucial underlying capabilities are:
It's not obvious to me that the new controls support that; do they? |
I would say that purely visual binary searching will be very simple to do with the slider I'm implementing in this PR - up to a certain precision. Pinpointing the exact timestamp on a slider will be hard because there won't be any zooming functionality in this version. Obviously zooming and panning through the timeline/slider will become even more important once we start adding metadata and that's why we're already planning to include it in the UI next iteration. @bia just started working on it, but you can see her initial prototype here. The idea would be that the timeline would replace the current slider and create a space inside it for the metadata. The timeline would be both zoomable and pannable. |
@rade @fbarl One of the main themes for us to tackle is to make visible 'interesting' moments in someone's history. These can be things like downtime in the system, or anything else that we'd eventually like to display as metadata. But before we get to that point and before we are able to zoom into the timeline to get more granularity, we could address this issue using the metaphor of a 'scan' button on a car radio. Say that your timeline ranges from 1t - 10t. Maybe interesting things have happened at 1.22t, 1.73t, 3.01t, and 4.00t. In that case, the slider could automatically snap to those timestamps instead of any arbitrary subdivision of your history. |
Making interesting moments visible in the timeline is no substitute for exploration. There can be all kinds of interesting events/conditions a user may be looking for that Weave Cloud hasn't captured explicitly. So, make exploration work well first, then add interesting events. |
cc710bb
to
1b228f7
Compare
Another way to think about this is the "video editing" metaphor, where a "visible window" can pan and zoom over a line, and the focus can be positioned within it.
|
720bb7d
to
0c4a229
Compare
4805749
to
a4e9bca
Compare
Looks slick! Simple a and clean, nicely done. Niggles:
Future designs?
|
a4e9bca
to
94da5e9
Compare
Resolves #2608 and also fixes #2653 and #2658.
Major changes
Pain points