rationalise report set usage #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are an implementation detail.
for efficiency and consistency
for consistency - all the other report set constructors are called 'Make...'
They were unused and their naming was inconsistent with similar operations (that are called Delete()).
It wasn't used, and is problematic in any case since it introduces non-monotonicity.
Mainly for consistencty; we do something similar NodeSet.Delete().
2opremio
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent APIs and usage of various set types on reports.
Also some micro optimizations, as a result of using the best available APIs; not enough to noticeably gain performance though.
See individual commits for details of what's been done; it's all largely mechanical.
I've done a before/after comparison of the generated topology reports to check that nothing has changed, and also that I didn't inadvertently introduce a performance regression.