New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve process code in probe #272

Merged

tomwilkie merged 1 commit into weaveworks:master from tomwilkie:process-details

Jun 23, 2015

Contributor

tomwilkie commented Jun 22, 2015

move pidtree into its own module
desegregate pidtree into tree, walker and reporter
extend tests
put command line in the process metadata

might help towards #238

tomwilkie assigned paulbellamy

tomwilkie force-pushed the process-details branch 2 times, most recently from be6c4d7 to 574379f Compare

June 22, 2015 18:00

paulbellamy reviewed

View reviewed changes

probe/docker/tagger.go

               	return r, nil
               }
-              func (t *Tagger) tag(pidTree tag.PIDTree, topology *report.Topology) {
+              func (t *Tagger) tag(pidTree process.Tree, topology *report.Topology) {

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the process-details branch from 574379f to a645956 Compare

June 23, 2015 09:12

paulbellamy reviewed

View reviewed changes

probe/process/walker.go

+              )
+              // Walk
+              var Walk = func(procRoot string, f func(*Process)) error {

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the process-details branch from a645956 to 16bba90 Compare

June 23, 2015 09:15

paulbellamy reviewed

View reviewed changes

render/detailed_node.go

-              	}
-              	if val, ok := nmd["ppid"]; ok {
-              		rows = append(rows, Row{"Parent PID", val, ""})
+              	for _, tuple := range []struct{ key, human string }{

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the process-details branch from 16bba90 to 8c694e3 Compare

June 23, 2015 09:32

paulbellamy reviewed

View reviewed changes

probe/process/walker.go

+              		if err != nil {
+              			continue
+              		}
+              		splits := strings.Split(string(stat), " ")

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the process-details branch from 8c694e3 to e68cb7d Compare

June 23, 2015 09:35

paulbellamy reviewed

View reviewed changes

probe/process/walker.go

+              		cmdline := ""
+              		if cmdlineBuf, err := ReadFile(path.Join(procRoot, filename, "cmdline")); err == nil {
+              			cmdlineBuf = bytes.Replace(cmdlineBuf, []byte{'\000'}, []byte{' '}, -1)

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the process-details branch from e68cb7d to daeba37 Compare

June 23, 2015 09:38


          Refactor PIDTree

560cf66

- Move pidtree to its own module and disaggregate it into tree, walker and reporter.
- Extend testing for probe/process
- Extend process metadata; add command line & # threads.

tomwilkie force-pushed the process-details branch from daeba37 to 560cf66 Compare

June 23, 2015 09:40

Contributor

paulbellamy commented Jun 23, 2015

LGTM

tomwilkie added a commit that referenced this pull request


          Merge pull request #272 from tomwilkie/process-details

d3d10fe

Improve process code in probe

tomwilkie merged commit d3d10fe into weaveworks:master

tomwilkie deleted the process-details branch

June 23, 2015 09:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet