Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of react-tooltip dependency #2871

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Sep 28, 2017

Fixes #2869.

The positioning of our own component is not that robust but it does the job for now. Tested on all plugins from https://github.com/weaveworks-plugins (by mocking their titles and descriptions).

@fbarl fbarl self-assigned this Sep 28, 2017
@fbarl fbarl requested a review from jpellizzari September 28, 2017 11:23
@fbarl fbarl changed the title 2869 get rid of react tooltip Get rid of react-tooltip dependency Sep 28, 2017
@fbarl fbarl merged commit ae5d8a9 into master Oct 4, 2017
@fbarl fbarl deleted the 2869-get-rid-of-react-tooltip branch October 20, 2017 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants