Avoid object creation when scanning DNS names #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we do this a lot, scanning the lists in-place saves time. Also we don't need to sort them since StringSet is implemented as a sorted set of strings
rade
approved these changes
Nov 5, 2017
rade
reviewed
Nov 5, 2017
| // DNSFirstMatch returns the first DNS name where match() returns | ||
| // true, from a prioritized list of snooped and reverse-resolved DNS | ||
| // names associated with node n. | ||
| func DNSFirstMatch(n report.Node, match func(name string) bool) (string, bool) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do this a lot, scanning the lists in-place saves work.
Also we don't need to sort them since StringSet is implemented as a sorted set of strings
It's actually benchmarking a little slower, when the best of five runs is taken, but with reduced memory allocation. The timing of this benchmark is highly variable on my VM; the new benchmarks in #2920 are more reliably faster with this change.
Before
After