Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all memoisation and then re-introduce it a) for top-level renderes, i.e. those closest to the API, and b) shared renderes.
This cuts the number of memoising renderers from 74 to 21.
I ran a number of tests with a recent prod report
and then timed the fetching of topologies with
rpeat = fetching the same topology again
ahost = fetching the topology after first fetching the host topology
hits = memoisation cache hits during fetch / rpeat fetch / ahost fetch
Timings are best run out of five.
So there really is no difference in timing, but it should consume less memory.
Each of the memoisations does have an effect, often very substantial; i.e. disabling any one increases at least one of the numbers above.
Fixes #2923