Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect reporting of replicaset DesiredReplicas #2955

Merged
merged 1 commit into from
Dec 1, 2017
Merged

fix incorrect reporting of replicaset DesiredReplicas #2955

merged 1 commit into from
Dec 1, 2017

Conversation

rade
Copy link
Member

@rade rade commented Nov 30, 2017

ReplicaSetSpec.Replicas is an *int32. Just like in DeploymentSpec, where we deal with that in the same way.

I stumbled across this when looking at a report...

          "kubernetes_desired_replicas": {
            "timestamp": "2017-11-30T15:40:13.064620595Z",
            "value": "0xc42fd73888"
          },

Oops.

@rade
fix incorrect reporting of replicaset DesiredReplicas
914acf6 
ReplicaSetSpec.Replicas is an *int32. Just like in DeploymentSpec,
where we deal with that in the same way.
@rade rade requested a review from bboreham November 30, 2017 18:44
@rade rade merged commit 2f4c650 into master Dec 1, 2017
@rade rade deleted the fix-replicaset-desiredreplicas branch December 25, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rade @bboreham