remove Node.Edges #2992
Merged
remove Node.Edges #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unused and none of the adjacency mapping code in the renderer takes any notice of it. Removing this shrinks the report size. Edges were introduced in #838. At the time we had an experimental packet sniffer under experimental/sniff/sniffer.go. That got removed in #1646. We can resurrect this if we ever decide to add meta data to edges.
|
There are a number of comments in |
bboreham
approved these changes
Dec 17, 2017
Adjacencies are edges; we use the two terms interchangeably. I've updated the comments to clarify that relationship, and removed vestiges of edge metadata from comments too, and fixed an incorrect "are not present" assertion (edges on Overlay are present). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unused and none of the adjacency mapping code in the renderer takes any notice of it. Removing this shrinks the report size.
Edges were introduced in #838. At the time we had an experimental packet sniffer under experimental/sniff/sniffer.go. That got removed in #1646.
We can resurrect this if we ever decide to add meta data to edges.