make Report.Topology(name) fast
#3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was buidling a fresh map of all topologies, just so it could look up the one given as an argument. Node summarisation (via detailed.Summaries) in particular was badly affected by that.
|
benchmarks from running master branch |
Having 6 lists of topolgies in the same file is a bit much: 1. consts for topology names 2. Report type definition 3. MakeReport() Report initialisation 4. Report.Topology(name) lookup 5. Report.TopologyMap() mapping of names to topology references 6. Report.WalkPairedTopologies() iterator over topology references We get rid of 5 and 6 by introducing a topologyNames slice. So we are down to 5. We replace Report.TopologyMap() with a new function, WalkNamedTopologies, that uses topologyNames. WalkPairedTopologies() is updated to operate in a similar fashion. Likewise for WalkTopologies() and Topologies() - these were previously calling Walk[Paired]Topologies, but it is clearer to simply implement them directly.
The three report.Walk* functions are quite enough.
rade
force-pushed
the
fast-topology-lookup
branch
from
760862c to
dcda884
Compare
|
I've merged this since it's all pretty straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was buidling a fresh map of all topologies, just so it could look up the one given as an argument.
Node summarisation (via
detailed.Summaries()) in particular was badly affected by that.