-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying backgrounds to match lightgray in service-ui and ui-compo… #3011
Conversation
The highlighting of the controls at the top is rather faint. |
That looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...which has just reminded me to ask... why is there such a huge gap between the top controls and the table? Vertical space is precious here; the table should use as much as it can. Separate issue, clearly. |
Ah, I think it's there to accommodate the expansion of the top when timetravelling. |
@rade, but it shouldn't be that way when in Live mode? |
Ideally not, no. Have filed #3015. |
…nents
Breaks unless service-ui is also updated to https://github.com/weaveworks/service-ui/pull/1672
The corresponding gray shift in Explore to addresses the issues in weaveworks/ui-components#93
Trying to consolidate and simplify some colouring and settled on this after quite a few more more drastic attempts..
Is this enough contrast?