Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pausedAt format from moment() back to ISO string #3036

Merged
merged 2 commits into from
Jan 22, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jan 19, 2018

Resolves #3029.

Everything should be working as before :)

@fbarl fbarl self-assigned this Jan 19, 2018
@fbarl fbarl requested a review from rndstr January 19, 2018 16:23
@fbarl fbarl force-pushed the 3029-change-paused-at-timestamp-back-to-string branch from 65e3a5c to 77b691c Compare January 19, 2018 18:26
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, only niggles

@@ -23,7 +24,7 @@ export function appendTime(url, time) {
const json = decodeURIComponent(url.substr(pos + cloudLinkPathEnd.length));
try {
payload = JSON.parse(json);
payload.time = { queryEnd: time.unix() };
payload.time = { queryEnd: moment(time).unix() };

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@@ -23,7 +24,7 @@ export function appendTime(url, time) {
const json = decodeURIComponent(url.substr(pos + cloudLinkPathEnd.length));
try {
payload = JSON.parse(json);
payload.time = { queryEnd: time.unix() };
payload.time = { queryEnd: moment(time).unix() };

This comment was marked as abuse.

This comment was marked as abuse.

@fbarl fbarl merged commit c56ff7e into master Jan 22, 2018
@fbarl fbarl deleted the 3029-change-paused-at-timestamp-back-to-string branch February 9, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants