Fetch cronjobs from 'batch/v1beta1' #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded from 99c19923, branch release-3.0. This required fetching or upgrading the following: * k8s.io/api to kubernetes-1.9.1 * k8s.io/apimachinery to kubernetes-1.9.1 * github.com/juju/ratelimit to 1.0.1 * github.com/spf13/pflag to 4c012f6d Also, update Scope's imports/function calls to be compatible with the new client.
rbruggem
force-pushed
the
cronjobs-1.8
branch
from
5695dfc to
d3021d5
Compare
rade
approved these changes
Jan 30, 2018
probe/kubernetes/client.go
Outdated
| @@ -175,6 +180,20 @@ func (c *client) setupStore(kclient rest.Interface, resource string, itemType in | |||
| return store | |||
| } | |||
|
|
|||
| func (c *client) setupCronjobsStore() (cache.Store, error) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
probe/kubernetes/cronjob.go
Outdated
| @@ -74,3 +86,29 @@ func (cj *cronJob) GetNode() report.Node { | |||
| } | |||
| return cj.MetaNode(report.MakeCronJobNodeID(cj.UID())).WithLatests(latest) | |||
| } | |||
|
|
|||
| func upgrade(legacy *batchv2alpha1.CronJob) *batchv1beta1.CronJob { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This applies if kubernetes' version is >= 1.8. Otherwise fetch cronjobs from 'batch/v2alpha1'.
rbruggem
force-pushed
the
cronjobs-1.8
branch
from
d3021d5 to
f4b55b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies if kubernetes' version is >= 1.8.
Otherwise fetch cronjobs from 'batch/v2alpha1'.
Also, upgrade k8s.io/client-go to kubernetes-1.9.1.
Tested with kubernetes 1.7 and 1.9.
Fixes #3032.