Simplify Map.Render() #3135
Merged
Simplify Map.Render() #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last MapFunc which returns multiple Nodes, so by turning it into a Renderer we open the door to simplifing every other MapFunc.
Save time creating a map for the results which contains at most one entry
joinResults grew out of a special case of Map.Render(), so now we merge the two lines back together and have just one way to accumulate results and remap adjacencies.
rade
approved these changes
Apr 9, 2018
render/render.go
Outdated
| // If the output is empty, the node shall be omitted from the rendered topology. | ||
| type MapFunc func(report.Node) report.Nodes | ||
| // If the output ID is blank, the node shall be omitted from the rendered topology. | ||
| type MapFunc func(report.Node) report.Node |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all
MapFuncs return a singleNodeinstead of a set.This lets us save a bit of time by not creating all those
maps, and re-integrate the adjacency mapping code that was split out intojoinResults.Benchmarks, using a set of reports from Weave Cloud - the timings are a bit mixed but bytes and allocations are generally in the right direction: