Add CLI flag for SQS RPC timeout #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jml
approved these changes
May 3, 2018
leth
changed the title
|
The description of this PR should include why it was done, so it can be understood without reference to a private repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to configure the timeout to be lower than the upstream authenticating proxy, so that RPC timeouts are sent to the client rather than generic 504 errors from the proxy.
Happy to change the new threshold, I (mostly) picked the number out of the air!
I considered adjusting the historgram buckets to fit with this number, but wasn't sure what to pick.