Show image tag in node details #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
3161-show-image-tag
branch
3 times, most recently
from
941fec9 to
ad6d996
Compare
fbarl
changed the title
lilic
reviewed
May 16, 2018
probe/docker/registry.go
Outdated
| // ImageNameWithoutVersion splits the image name apart, returning the name | ||
| // without the version, if possible | ||
| func ImageNameWithoutVersion(name string) string { | ||
| // ImageNameParts returns parts of the full image name (image name, image tag). |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
probe/docker/registry.go
Outdated
|
|
||
| // ImageNameWithoutVersion splits the image name apart, returning the name | ||
| // without the version, if possible | ||
| func ImageNameWithoutVersion(name string) string { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@lilic PTAL. |
fbarl
force-pushed
the
3161-show-image-tag
branch
from
8e846b7 to
bfb20a8
Compare
lilic
reviewed
May 17, 2018
| ImageName: "Name", | ||
| // Prepend spaces as a hack to keep at the top when sorted. | ||
| ImageID: " ID", | ||
| ImageName: " Name", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3161.