Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TimestampTag component #3195

Merged
merged 1 commit into from
May 28, 2018
Merged

Use TimestampTag component #3195

merged 1 commit into from
May 28, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 28, 2018

Closes https://github.com/weaveworks/service-ui/issues/2538.

Using <TimestampTag /> component in only one place in Scope:

image

@fbarl fbarl self-assigned this May 28, 2018
@fbarl fbarl requested a review from foot May 28, 2018 14:46
foot
foot approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut! lgtm

@fbarl fbarl merged commit 6ded495 into master May 28, 2018
@fbarl fbarl deleted the 2538-use-timestamp-tag branch May 28, 2018 16:36
@bboreham
Copy link
Collaborator

Please note, the title and description of any PR should be written to be understood by a casual visitor, without reference to private repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbarl @bboreham @foot